fix(deploy): align Trigger.dev workers with ECS releases - #7698
Draft
BillLeoutsakosvl346 wants to merge 1 commit into
Draft
fix(deploy): align Trigger.dev workers with ECS releases#7698BillLeoutsakosvl346 wants to merge 1 commit into
BillLeoutsakosvl346 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An ECS app release can currently run against a different Trigger.dev worker version, and a successful image promotion does not establish that AWS deployed it. Align both sides using the full commit SHA and extend the existing deployment path instead of introducing a release orchestrator or state store.
COMMIT_SHAin app images and pin worker-originated jobs to the executing worker version. Hosted discovery is enabled by the companion infra change; public images do not enable it themselves.Companion drafts: hosted infra configuration and runbook, dev duplicate-trigger cleanup.
Type of Change
Testing
No YAML snapshots or duplicate queue/secret-loader tests were added. No deployments were executed. The non-production release/repeat/partial-failure/stale-release/rollback exercise remains pending.
Rollout prerequisites
Keep the change in draft until live AWS/Trigger metadata and configuration are verified. Before enabling hosted pinning, establish the app/worker SHA baseline, confirm producer mappings and retained worker/image versions, and resolve any configuration that overrides SHA discovery. CI needs metadata-read permissions and a 5400-second AWS role session. IAM/ECR policy ownership and live drift remain unverified; secret synchronization belongs to its separate investigation. The companion infra README contains rollout and recovery instructions.
Checklist